Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(icons): move componets/icon to elements/icons #18316

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

makafsal
Copy link
Member

@makafsal makafsal commented Jan 9, 2025

Closes #17936

Moved components/icon to elements/icons to sync with React

Changelog

New

  • A new Elements section in Storybook

Changed

  • Moved components/icon stories to elements/icons
  • Renamed icon.* files to icons.*

Removed

  • Stories components/icon

Testing / Reviewing

  1. Direct to web-components storybook
  2. Scroll down in the left sidebar to find the new Elements section
  3. Can find the Icons stories there

@makafsal makafsal requested a review from a team as a code owner January 9, 2025 05:55
Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 30b8212
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/677f64bb3735200008ae736b
😎 Deploy Preview https://deploy-preview-18316--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 30b8212
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/677f64bb9f74d9000816dd6a
😎 Deploy Preview https://deploy-preview-18316--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 30b8212
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/677f64bb663b8b00087488a9
😎 Deploy Preview https://deploy-preview-18316--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (9217609) to head (30b8212).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18316   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files         408      408           
  Lines       14435    14435           
  Branches     4690     4690           
=======================================
  Hits        12150    12150           
  Misses       2120     2120           
  Partials      165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React|WC Parity: Icon
3 participants