-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(icons): move componets/icon to elements/icons #18316
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18316 +/- ##
=======================================
Coverage 84.17% 84.17%
=======================================
Files 408 408
Lines 14435 14435
Branches 4690 4690
=======================================
Hits 12150 12150
Misses 2120 2120
Partials 165 165 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #17936
Moved
components/icon
toelements/icons
to sync with ReactChangelog
New
Elements
section in StorybookChanged
components/icon
stories toelements/icons
icon.*
files toicons.*
Removed
components/icon
Testing / Reviewing
Elements
sectionIcons
stories there