-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added open in Stackblitz to stories #18309
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18309 +/- ##
==========================================
+ Coverage 84.15% 84.17% +0.01%
==========================================
Files 406 408 +2
Lines 14407 14435 +28
Branches 4686 4640 -46
==========================================
+ Hits 12124 12150 +26
- Misses 2119 2121 +2
Partials 164 164 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great and is going to be so useful! 🥳 Seems like there are a handful of components not included that do have the Canvas component on their overview page, was there a reason they were excluded from this? (AILabel, AspectRatio, Grid...)
Example from AILabel. It looks weird 😅
Good catch! i rollback this one. I didn't look in depth on this one, but here it is an explanation on what is happening in Datatable and Notification stories. If guys see something that might be missing, let me know. |
Closes #18257
This PR adds the option to open a story in Stackblitz. That was not added to all stories, because a few stories do not have any
Canvas
to add this option or maybe it wasn't necessary. But we can improve our storybook docs along the way.Changelog
New
additionalActions
toCanvas
called "Open in Stackblitz"Testing / Reviewing