Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added open in Stackblitz to stories #18309

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Jan 8, 2025

Closes #18257

This PR adds the option to open a story in Stackblitz. That was not added to all stories, because a few stories do not have any Canvas to add this option or maybe it wasn't necessary. But we can improve our storybook docs along the way.

Changelog

New

  • Added the additionalActions to Canvas called "Open in Stackblitz"

Testing / Reviewing

  • CI should pass
  • Stories should work as expected
  • Try to open a few stories on Stackblitz

@guidari guidari requested a review from a team as a code owner January 8, 2025 18:41
@guidari guidari changed the title feat: Added opne in Stackblitz to stories feat: Added open in Stackblitz to stories Jan 8, 2025
Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit a1d1220
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/677ee25c5cf2fa00081bb164
😎 Deploy Preview https://deploy-preview-18309--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a1d1220
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/677ee25ca67c430008e8f6d6
😎 Deploy Preview https://deploy-preview-18309--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a1d1220
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/677ee25c7d6e1a0008e72b17
😎 Deploy Preview https://deploy-preview-18309--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (96b5a47) to head (d5fee4f).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18309      +/-   ##
==========================================
+ Coverage   84.15%   84.17%   +0.01%     
==========================================
  Files         406      408       +2     
  Lines       14407    14435      +28     
  Branches     4686     4640      -46     
==========================================
+ Hits        12124    12150      +26     
- Misses       2119     2121       +2     
  Partials      164      164              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and is going to be so useful! 🥳 Seems like there are a handful of components not included that do have the Canvas component on their overview page, was there a reason they were excluded from this? (AILabel, AspectRatio, Grid...)

@ariellalgilmore
Copy link
Member

so awesome!! seeing this on a few of the data-table overview pages though

Screenshot 2025-01-08 at 11 10 31 AM

@guidari
Copy link
Contributor Author

guidari commented Jan 8, 2025

@alisonjoseph

This looks great and is going to be so useful! 🥳 Seems like there are a handful of components not included that do have the Canvas component on their overview page, was there a reason they were excluded from this? (AILabel, AspectRatio, Grid...)

  • A couple stories depend on CSS or external files apart from the .story.js.
  • AspectRatio I just forgot to comeback and fixed
  • Grid and FlexGrid is another example that is missing CSS as well. But I added the Open in Stackblitz option and linked the CSS that the user would need to use to see the example. We can also remove the option from them if we want or add to AILabel and other stories that need CSS, I would like an second opinion on this topic, to know what is best to do.

Example from AILabel. It looks weird 😅

Screenshot 2025-01-08 at 17 26 05

@ariellalgilmore

so awesome!! seeing this on a few of the data-table overview pages though

Good catch! i rollback this one. I didn't look in depth on this one, but here it is an explanation on what is happening in Datatable and Notification stories.

If guys see something that might be missing, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create "Open in Stackblitz" option in Storybook Canvas
3 participants