Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enabling type imports directly from @carbon/react #18301

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Gururajj77
Copy link
Contributor

Closes #16436

enabling component's type imports directly from library's root.

Changelog

Changed

  • index.ts - imported component's prop type interfaces to root index.ts

Testing / Reviewing

can be tested only after merge, issues can be raised accordingly

Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit b95e65a
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/677d13a81175b400085f6185
😎 Deploy Preview https://deploy-preview-18301--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 5363de1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/677fc783635e550008bd1801
😎 Deploy Preview https://deploy-preview-18301--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit b95e65a
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/677d13a8e02bdb00085e308d
😎 Deploy Preview https://deploy-preview-18301--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: As a Developer, I would like to import types from @carbon/react
2 participants