Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React|WC Parity: Icon #17936

Closed
kennylam opened this issue Oct 31, 2024 · 0 comments · Fixed by #18316
Closed

React|WC Parity: Icon #17936

kennylam opened this issue Oct 31, 2024 · 0 comments · Fixed by #18316
Assignees
@makafsal
Labels
package: @carbon/web-components @carbon/web-components role: dev 🤖

Comments

@kennylam
Copy link
Member

kennylam commented Oct 31, 2024 •
edited by tay1orjones
Loading

See parent issue #17992 for acceptance criteria.

In addition to the sync work, this component is for internal usage and can be removed from Storybook.

Important

Every PR needs a ux and visual review from the design team to ensure consistency. Please be sure PRs have status: visual review 🔍 applied and request a review from @carbon-design-system/design
@kennylam kennylam mentioned this issue Oct 31, 2024
Open
@kennylam kennylam moved this to ⏱ Backlog in Design System Oct 31, 2024
@kennylam kennylam changed the title React|WC Parity: Icon (internal component - remove from Storybook) React|WC Parity: Icon Oct 31, 2024
@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Jan 7, 2025
@elycheea elycheea moved this from Needs triage 🧐 to Backlog 🌋 in Carbon for IBM Products Jan 7, 2025
@makafsal makafsal moved this from Backlog 🌋 to In progress in Carbon for IBM Products Jan 9, 2025
@makafsal makafsal moved this from ⏱ Backlog to 🏗 In Progress in Design System Jan 9, 2025
@makafsal makafsal mentioned this issue Jan 9, 2025
Merged
@makafsal makafsal moved this from 🏗 In Progress to 🚦 In Review in Design System Jan 9, 2025
@makafsal makafsal moved this from In progress to Needs review 👋 in Carbon for IBM Products Jan 9, 2025
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Jan 10, 2025
@github-project-automation github-project-automation bot moved this from Needs review 👋 to Done 🚀 in Carbon for IBM Products Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@makafsal makafsal

Labels
package: @carbon/web-components @carbon/web-components role: dev 🤖
Projects
Carbon for IBM Products
Status: Done 🚀
Design System
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(icons): move componets/icon to elements/icons makafsal/carbon
3 participants
@kennylam @makafsal @sstrubberg