Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip issue & Add support to custom endpoint_url, region_name and signature_version #43

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

M0dM
Copy link

@M0dM M0dM commented Dec 20, 2019

Trying to fix #42

I could not test it...
I have a strange issue on master :

    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/home/benoit/.local/share/virtualenvs/dxf_geom2d/src/kev/setup.py", line 2, in <module>
        from pip.req import parse_requirements
    ModuleNotFoundError: No module named 'pip.req'

Edit: pip issue (#44) Problem fixed by commit 613e2c7

I need also region_name argument to be set, I will try to add it as well in a new commit...
This will be easier as this attribute can be set directly when instanciating the session.

Edit: region_name and signature_version are also usefull to make kev work with minio

@M0dM M0dM changed the title Add proper support to custom endpoint_url Fix pip and add support to custom endpoint_url, and region_name Dec 20, 2019
@M0dM M0dM changed the title Fix pip and add support to custom endpoint_url, and region_name Fix pip issue & Add support to custom endpoint_url, and region_name Dec 20, 2019
@M0dM M0dM changed the title Fix pip issue & Add support to custom endpoint_url, and region_name Fix pip issue & Add support to custom endpoint_url, region_name and signature_version Dec 20, 2019
@M0dM
Copy link
Author

M0dM commented Dec 20, 2019

Everything seems to work well on my side.
As tests are completely broken, could you please test on your side and merge this if you find it legit.

Regards,

@bjinwright bjinwright changed the base branch from master to develop December 28, 2020 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work with custom endpoint_url & region_name
2 participants