Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to the wp theme list command #142

Merged
merged 6 commits into from
Oct 13, 2023
Merged

Add retries to the wp theme list command #142

merged 6 commits into from
Oct 13, 2023

Conversation

weiiwang01
Copy link
Collaborator

Overview

The feedwordpress plugin, version 2022.0222, intermittently causes failures when executing the wp theme list command. To address this issue, add retries to the command execution.

Juju Events Changes

None

Module Changes

None

Library Changes

None

Checklist

@weiiwang01 weiiwang01 added the bug Something isn't working label Oct 12, 2023
@weiiwang01 weiiwang01 requested a review from a team as a code owner October 12, 2023 14:44
mthaddon
mthaddon previously approved these changes Oct 12, 2023
Copy link
Contributor

@mthaddon mthaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the quick fix. We should circle back at some point, as the charm is currently sitting in blocked idle if this fails, without giving the user a way to proceed. But given this is somewhat time sensitive, I think it makes sense to land as is and address that later.

@mthaddon
Copy link
Contributor

I've created #143 to ensure we follow up on this at some point (the blocked idle issue, if the reconcile loop fails).

jdkandersson
jdkandersson previously approved these changes Oct 13, 2023
@weiiwang01 weiiwang01 dismissed stale reviews from jdkandersson and mthaddon via b5169fe October 13, 2023 07:42
merkata
merkata previously approved these changes Oct 13, 2023
@github-actions
Copy link
Contributor

Test coverage for e8a3c2e

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          521     37    168     29    90%   197-200, 551, 582, 628, 663-664, 715-722, 727, 829->834, 833, 835, 840-841, 901, 919, 926, 1018, 1027, 1039, 1060, 1069, 1088, 1092, 1121, 1174, 1306, 1328, 1335->1337, 1380->exit, 1392, 1424, 1433-1434
src/cos.py             15      0      0      0   100%
src/exceptions.py      17      1      2      1    89%   41
src/types_.py          15      0      0      0   100%
---------------------------------------------------------------
TOTAL                 568     38    170     30    90%

Static code analysis report

Run started:2023-10-13 11:58:40.819633

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4250
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@weiiwang01 weiiwang01 requested a review from mthaddon October 13, 2023 14:14
@weiiwang01 weiiwang01 merged commit 5b529cd into main Oct 13, 2023
@weiiwang01 weiiwang01 deleted the retry-theme-list branch October 13, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Libraries: Out of sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants