feat: Add widget for delaying errors on text fields #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1043 +/- ##
==========================================
+ Coverage 88.53% 89.19% +0.66%
==========================================
Files 112 113 +1
Lines 7499 7537 +38
==========================================
+ Hits 6639 6723 +84
+ Misses 684 637 -47
- Partials 176 177 +1 ☔ View full report in Codecov by Sentry. |
gui/packages/ubuntupro/lib/pages/widgets/delayed_text_field.dart
Outdated
Show resolved
Hide resolved
gui/packages/ubuntupro/lib/pages/widgets/delayed_text_field.dart
Outdated
Show resolved
Hide resolved
gui/packages/ubuntupro/lib/pages/widgets/delayed_text_field.dart
Outdated
Show resolved
Hide resolved
ashuntu
added a commit
that referenced
this pull request
Jan 13, 2025
… jittering (#1045) When entering text into a text field that may display an error, the text field and other content on the page will move to accomodate the error text. This change adds a SizedBox when there is no error to prevent this movement. As a result, page content is naturally longer, so the default window height has been increased by 50 pixels.  *Depends on #1043 --- UDENG-5680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a delay to error messages while typing in a text field. Notably, there is no delay when errors are removed.
UDENG-5681