Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set a maximum size of page contents #1042

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix: Set a maximum size of page contents #1042

merged 1 commit into from
Jan 8, 2025

Conversation

ashuntu
Copy link
Collaborator

@ashuntu ashuntu commented Jan 7, 2025

Sets a maximum width for page content, equal to their current effective width.

Here's a comparison for this change (maximized on a 1440p screen):

Old New
image image

The default size of the app remains unchanged.

This diff is really just the content being wrapped with a new widget, nothing else changed


UDENG-5684

@ashuntu ashuntu self-assigned this Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (5295e58) to head (fc0e6b0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1042   +/-   ##
=======================================
  Coverage   89.14%   89.14%           
=======================================
  Files         112      112           
  Lines        7498     7499    +1     
=======================================
+ Hits         6684     6685    +1     
  Misses        637      637           
  Partials      177      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashuntu ashuntu marked this pull request as ready for review January 7, 2025 22:46
@ashuntu ashuntu requested a review from a team as a code owner January 7, 2025 22:46
Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

It feels as though GH created the "Hide whitespace" feature for Flutter developers :)

image

@ashuntu ashuntu merged commit fc6bd2b into main Jan 8, 2025
37 checks passed
@ashuntu ashuntu deleted the maximum-size branch January 8, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants