Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work/craft 3831 starflow #782

Merged
merged 25 commits into from
Dec 21, 2024
Merged

Work/craft 3831 starflow #782

merged 25 commits into from
Dec 21, 2024

Conversation

tigarmo
Copy link
Collaborator

@tigarmo tigarmo commented Dec 20, 2024

  • Have you signed the CLA?

@tigarmo tigarmo force-pushed the work/CRAFT-3831-starflow branch 6 times, most recently from d462956 to e66abe6 Compare December 20, 2024 17:16
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 20, 2024
@tigarmo tigarmo added the rebase label Dec 20, 2024
@tigarmo tigarmo marked this pull request as ready for review December 20, 2024 17:30
@tigarmo tigarmo requested a review from lengau December 20, 2024 17:30
@bepri bepri self-requested a review December 20, 2024 17:46
bepri
bepri requested changes Dec 20, 2024
View reviewed changes
Copy link

@bepri bepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! In my testing, I was able to use the new makefile to create a dev environment from scratch, run the linters, and then package rockcraft's snap. Just a couple potential stragglers I spotted.

pyproject.toml Outdated Show resolved Hide resolved
common.mk Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
lengau
lengau approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I agree that the pylint changes should be in a separate PR

@tigarmo tigarmo requested a review from bepri December 20, 2024 19:44
tigarmo added 14 commits December 21, 2024 11:21
@tigarmo
chore: add pre-commit-config from starbase
cf48cfc
@tigarmo
build(snap): use uv to build the snap
1e148f6
@tigarmo
build: add Makefile and common.mk from starbase
ecdb3f6
@tigarmo
style: run 'make format'
602033b
@tigarmo
chore: add lint and types deps
288843d
@tigarmo
style(yaml): disable yammlint for now
866ccd2 
Rockcraft's various yamls are all over the place and will need a dedicated
PR to fix.
@tigarmo
build: fix optional dependencies
caf1547 
Don't list redundant deps in 'dev' and elsewhere, and rename 'doc' to 'docs' as
that's what the Makefile uses.
@tigarmo
chore: update sphinx-lint call
77e4f4a
@tigarmo
chore: fix for lint-twine
15bfcaa
@tigarmo
chore(tests): mark >1s tests as slow
6f02e6b
@tigarmo
ci: use QA workflows from starflow
7a15d8e
@tigarmo
chore: disable bad linters in sphinx-lint
1b03525 
missing-underscore/space breaks with literalrefs.
@tigarmo
build: don't build on macos
26268ad
@tigarmo
build(deps): temporarily restrict craft-app and craft-parts
f4f6cb1 
The newest versions of those libraries make tests fail, and that should be
addressed in a separate task.
@tigarmo tigarmo force-pushed the work/CRAFT-3831-starflow branch from b6fbb71 to 0f09cf1 Compare December 21, 2024 14:24
@tigarmo tigarmo merged commit 8ea35b0 into main Dec 21, 2024
18 checks passed
@tigarmo tigarmo deleted the work/CRAFT-3831-starflow branch December 21, 2024 15:47
@tigarmo tigarmo mentioned this pull request Dec 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bepri bepri bepri approved these changes

@lengau lengau lengau approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tigarmo @lengau @bepri