Get ROCK image right tag considering the latest merged rock files

[amandahla]

Applicable spec:

Overview

What happened in Synapse:

24 Nov: I submitted a WIP PR that changes the ROCK images canonical/synapse-operator#111
27 Nov: Publish to Edge workflow sucessfully ran with merged changes (update jsonschema)
27 Nov: I refreshed Synapse charm in production to apply the fix regarding nginx pebble ready event (23 Nov) + this last one regarding jsonschema
For my huge surprise: Synapse image is running the latest Synapse version as was changed in the WIP PR

Rationale

Make publish charm get the latest image from the latest merged PR and not the latest uploaded.

Workflow Changes

Checklist

• The contributing guide was applied
• The PR is tagged with appropriate label (urgent, trivial, complex)

[arturo-seijas]

LGTM :) Thanks!

[weiiwang01]

The problem of using head_sha is that we are using the squash merge, which causes the commit in main branch is different with the commit in the pull request.

For example, the commit in main branch is canonical/synapse-operator@7defdb4, but the corresponding commit in pull request is canonical/synapse-operator@1e13c04.

Unfortunately, tests inside this repository don't reflect that situation.

[weiiwang01]

The problem of using head_sha is that we are using the squash merge, which causes the commit in main branch is different with the commit in the pull request.

For example, the commit in main branch is canonical/synapse-operator@7defdb4, but the corresponding commit in pull request is canonical/synapse-operator@1e13c04.

Unfortunately, tests inside this repository don't reflect that situation.

I think something like this should work:

# Get commit info
TREE_SHA=$(gh api \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  /repos/${{ github.repository }}/commits/${GITHUB_SHA} \
   --jq '.commit.tree.sha')
# Get workflow from this specific tree id
RUN_ID=$(gh api \
  --method GET \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  /repos/${{ github.repository }}/actions/runs \
  -f path=.github/workflows/integration_test.yaml \
  -f status=completed \
  -f event=pull_request \
  --jq "[
          .workflow_runs[]
          | select(.path == \".github/workflows/integration_test.yaml\")
          | select(.head_commit.tree_id == \"$TREE_SHA\")
        ] | max_by(.updated_at) | .id")

[amandahla]

The problem of using head_sha is that we are using the squash merge, which causes the commit in main branch is different with the commit in the pull request.
For example, the commit in main branch is canonical/synapse-operator@7defdb4, but the corresponding commit in pull request is canonical/synapse-operator@1e13c04.
Unfortunately, tests inside this repository don't reflect that situation.

I think something like this should work:

# Get commit info
TREE_SHA=$(gh api \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  /repos/${{ github.repository }}/commits/${GITHUB_SHA} \
   --jq '.commit.tree.sha')
# Get workflow from this specific tree id
RUN_ID=$(gh api \
  --method GET \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  /repos/${{ github.repository }}/actions/runs \
  -f path=.github/workflows/integration_test.yaml \
  -f status=completed \
  -f event=pull_request \
  --jq "[
          .workflow_runs[]
          | select(.path == \".github/workflows/integration_test.yaml\")
          | select(.head_commit.tree_id == \"$TREE_SHA\")
        ] | max_by(.updated_at) | .id")

Thanks!!

[yanksyoon]

LGTM!