fix: side panel fieldless forms spacing (#5245)

canonical · Dec 15, 2023 · 97186a9 · 97186a9
1 parent 4f58969
commit 97186a9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/app/base/components/AppSidePanel/AppSidePanel.tsx b/src/app/base/components/AppSidePanel/AppSidePanel.tsx
@@ -68,7 +68,6 @@ const AppSidePanelContent = ({
                 <h3 className="section-header__title u-flex--no-shrink p-heading--4">
                   {title}
                 </h3>
-                <hr />
               </div>
             </div>
           ) : null}

diff --git a/src/app/base/components/FormikFormContent/FormikFormContent.tsx b/src/app/base/components/FormikFormContent/FormikFormContent.tsx
@@ -173,7 +173,8 @@ const FormikFormContent = <V extends object, E = null>({
       inline={inline}
       onSubmit={handleSubmit}
     >
-      <ContentSection>
+      {/* collapse content section when there's no content */}
+      <ContentSection className={!children ? "u-no-padding--top" : undefined}>
         <ContentSection.Content>
           {!!nonFieldError && (
             <Notification severity="negative" title="Error:">
@@ -184,7 +185,9 @@ const FormikFormContent = <V extends object, E = null>({
             ? children({ ...formikContext })
             : children}
         </ContentSection.Content>
-        <ContentSection.Footer>
+        <ContentSection.Footer
+          className={!children ? "u-no-margin--top" : undefined}
+        >
           {editable && (
             <FormikFormButtons
               {...buttonsProps}
-Original file line number
+Diff line change
@@ Expand Up / @@ -68,7 +68,6 @@ const AppSidePanelContent = ({ @@
                     <h3 className="section-header__title u-flex--no-shrink p-heading--4">
                       {title}
                     </h3>
-                    <hr />
                   </div>
                 </div>
               ) : null}
@@ Expand Down @@