refactor: controller statusSelectors (#5462)

Signed-off-by: Peter Makowski <[email protected]>

src/app/controllers/components/ControllerForms/ControllerActionFormWrapper/ControllerActionFormWrapper.tsx

@@ -55,12 +55,13 @@ export const ControllerActionFormWrapper = ({
   const processingControllers = useSelector(
     actionStatus ? statusSelectors[actionStatus] : () => []
   );
+  const controllerSystemIds = controllers.map(({ system_id }) => system_id);
   // The form expects one error, so we only show the latest error with the
   // assumption that all selected controllers fail in the same way.
   const errors = useSelector((state: RootState) =>
     controllerSelectors.eventErrorsForControllers(
       state,
-      controllers.map(({ system_id }) => system_id),
+      controllerSystemIds,
       kebabToCamelCase(action)
     )
   )[0]?.error;

src/app/store/controller/selectors.ts

@@ -61,20 +61,21 @@ const processing = (state: RootState): Controller[ControllerMeta.PK][] =>
     )
   );
 
-export const statusSelectors: {
-  [x: string]: Selector<RootState, Controller[]>;
-} = {};
-
 // Create a selector for each controller status.
-ACTIONS.forEach(({ status }) => {
-  statusSelectors[status] = createSelector(
-    [defaultSelectors.all, statuses],
-    (controllers: Controller[], statuses: ControllerStatuses) =>
-      controllers.filter(
-        ({ system_id }) => statuses[system_id][status as keyof ControllerStatus]
-      )
-  );
-});
+export const statusSelectors = ACTIONS.reduce(
+  (selectors, { status }) => {
+    selectors[status] = createSelector(
+      [defaultSelectors.all, statuses],
+      (controllers: Controller[], statuses: ControllerStatuses) =>
+        controllers.filter(
+          ({ system_id }) =>
+            statuses[system_id][status as keyof ControllerStatus]
+        )
+    );
+    return selectors;
+  },
+  {} as { [x: string]: Selector<RootState, Controller[]> }
+);
 
 /**
  * Get the statuses for a controller.