Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: fix image-mint.yml syntax #148

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

simondeziel
Copy link
Member

@simondeziel simondeziel commented Apr 18, 2024

Before that:

$ yamllint .github/workflows/image-mint.yml 
.github/workflows/image-mint.yml
  1:1       warning  missing document start "---"  (document-start)
  3:1       warning  truthy value should be one of [false, true]  (truthy)
  52:81     warning  line too long (93 > 80 characters)  (line-length)
  81:6      error    syntax error: expected <block end>, but found '<block sequence start>' (syntax)
  86:81     warning  line too long (110 > 80 characters)  (line-length)

After that adding the missing space:

$ yamllint .github/workflows/image-mint.yml 
.github/workflows/image-mint.yml
  1:1       warning  missing document start "---"  (document-start)
  3:1       warning  truthy value should be one of [false, true]  (truthy)
  52:81     warning  line too long (93 > 80 characters)  (line-length)
  86:81     warning  line too long (111 > 80 characters)  (line-length)

@MusicDin
Copy link
Member

I was looking into it and couldn't spot it. Thanks!

@simondeziel simondeziel marked this pull request as ready for review April 18, 2024 19:01
@simondeziel
Copy link
Member Author

I was looking into it and couldn't spot it. Thanks!

Yeah, I used meld .github/workflows/image-{mint,ubuntu}.yml to spot the difference.

This speaks that we need a YAML linter in our CI.

@MusicDin
Copy link
Member

MusicDin commented Apr 18, 2024

Agree, that would help tremendously, especially with those workflow files.

@tomponline tomponline merged commit 8a54b92 into canonical:main Apr 18, 2024
63 checks passed
@simondeziel simondeziel deleted the fix-mint-yaml branch April 18, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants