Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move charm install files to charm/howto/install #955

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Conversation

eaudetcobello
Copy link
Contributor

@eaudetcobello eaudetcobello commented Jan 13, 2025

Create the Install Canonical Kubernetes dropdown in Charm table of contents.

@eaudetcobello eaudetcobello requested a review from a team as a code owner January 13, 2025 20:40
@eaudetcobello eaudetcobello changed the title move install files to charm/howto/install move charm install files to charm/howto/install Jan 13, 2025
@bschimke95
Copy link
Contributor

The PR description claims that Uninstall instructions are added in this PR but I don't see them in the changes. Please either include them or update the description.

@eaudetcobello
Copy link
Contributor Author

The PR description claims that Uninstall instructions are added in this PR but I don't see them in the changes. Please either include them or update the description.

Please forgive this outrageous lie. I've amended the description.

Copy link
Contributor

@nhennigan nhennigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update where these files are referenced in the rest of the docs. I found docs/canonicalk8s/src/charm/howto/cos-lite.md links to charm.md which I think is the only other place but worth double checking

@eaudetcobello eaudetcobello merged commit db7134b into main Jan 14, 2025
6 checks passed
@eaudetcobello eaudetcobello deleted the KU-2397 branch January 14, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants