-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Terraform Documentation for k8s, k8s-worker charms #920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small nits to help improve the flow but overall great work 😺
| - | - | - | - | - | | ||
| `app_name`| string | Application name | False | k8s | | ||
| `base` | string | Ubuntu base to deploy the charm onto | False | [email protected] | | ||
| `channel`| string | Channel that the charm is deployed from | False | 1.30/edge | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 1.30/edge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't catch this in the k8s-operator PR, so I'll bump it with the next terraform work (openstack) and its complementary documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying those changes. 😃
Add Terraform docs for k8s, k8s-worker charms
This PR adds documentation on the k8s and k8s-worker terraform modules.