Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dualstack yaml indentation #914

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix dualstack yaml indentation #914

merged 1 commit into from
Dec 18, 2024

Conversation

bschimke95
Copy link
Contributor

The YAML file in the tutorial had incorrect indentation, resulting in the following error when applying the manifest:

ubuntu@juju-f7d895-1:~$ sudo k8s kubectl apply -f https://raw.githubusercontent.com/canonical/k8s-snap/main/docs/src/assets/how-to-dualstack-manifest.yaml
error: error parsing https://raw.githubusercontent.com/canonical/k8s-snap/main/docs/src/assets/how-to-dualstack-manifest.yaml: error converting YAML to JSON: yaml: line 17: mapping values are not allowed in this context

@bschimke95 bschimke95 requested a review from a team as a code owner December 18, 2024 12:48
berkayoz
berkayoz approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschimke95 bschimke95 merged commit 120d1db into main Dec 18, 2024
6 checks passed
@bschimke95 bschimke95 deleted the bschimke95/fix-dualstack-docs branch December 18, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkayoz berkayoz berkayoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bschimke95 @berkayoz