integration: completely remove LocalHarness. #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
reviewed
Dec 17, 2024
aznashwan
force-pushed
the
integration-remove-local-harness
branch
from
9691673 to
034fa8b
Compare
The LocalHarness is a harness used for running integration tests on the local machine where the tests are directly invoked (be it via `tox`, `pytest`, etc). It presents numerous limitations (can't run any multi-node tests) and poses a lot of potential risks (cleanup failing in case of fatal errors in the test fixtures) which outweighs most of its convenience benefits (especially when compared to the LXD substrate). This patch completely removes the LocalHarness and all references to it from the documentation, making LXD the new default. Signed-off-by: Nashwan Azhari <[email protected]>
aznashwan
force-pushed
the
integration-remove-local-harness
branch
from
034fa8b to
650e27f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LocalHarness is a harness used for running integration tests
on the local machine where the tests are directly invoked
(be it via
tox,pytest, etc).It presents numerous limitations (can't run any multi-node tests)
and poses a lot of potential risks (cleanup failing in case of
fatal errors in the test fixtures) which outweighs most of its
convenience benefits (especially when compared to the LXD
substrate).
This patch completely removes the LocalHarness and all references to it
from the documentation, making LXD the new default.