Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement TestValidateCAPIAuthTokenAccessHandler #885

Merged
merged 11 commits into from
Dec 11, 2024
Merged

implement TestValidateCAPIAuthTokenAccessHandler #885

merged 11 commits into from
Dec 11, 2024
+272 −38

Conversation

eaudetcobello
Copy link
Contributor

@eaudetcobello eaudetcobello commented Dec 11, 2024 •
edited
Loading

  • TestValidateCAPIAuthTokenAccessHandler
  • rename WithDB to WithState and move to a new location with package name microcluster_testenv
  • WithState gives access to the whole state.State type instead of state.State.Database() only

Depends on #880

@eaudetcobello eaudetcobello requested a review from a team as a code owner December 11, 2024 00:27
@eaudetcobello eaudetcobello force-pushed the KU-1893/capi-access-handler branch from 43fb0d4 to cdaf609 Compare December 11, 2024 00:49
@eaudetcobello eaudetcobello changed the base branch from main to KU-1893/node-access-handler December 11, 2024 00:49
bschimke95
bschimke95 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/k8s/pkg/k8sd/api/capi_access_handler_test.go Outdated Show resolved Hide resolved
HomayoonAlimohammadi
HomayoonAlimohammadi approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @eaudetcobello, LGTM!

src/k8s/pkg/k8sd/api/capi_access_handler_test.go Outdated Show resolved Hide resolved
@eaudetcobello eaudetcobello force-pushed the KU-1893/capi-access-handler branch from cdaf609 to cc3022a Compare December 11, 2024 19:19
@eaudetcobello
canonical header format
baa197e
@eaudetcobello
implement TestValidateCAPIAuthTokenAccessHandler
868312e 
* TestValidateCAPIAuthTokenAccessHandler
* rename WithDB to WithState and move to a new location with
package name microcluster_testenv
* WithState gives access to the whole state.State type instead of
state.State.Database() only
@eaudetcobello
use constant header name
45a486f
@eaudetcobello
revert token header name consts
ec32aa0
@eaudetcobello
microcluster_testenv -> testenv
b55ed92
@eaudetcobello
canonical header format
fc95f36
@eaudetcobello eaudetcobello force-pushed the KU-1893/capi-access-handler branch from 2715038 to fc95f36 Compare December 11, 2024 20:05
Base automatically changed from KU-1893/node-access-handler to main December 11, 2024 21:57
@eaudetcobello eaudetcobello merged commit e0561eb into main Dec 11, 2024
17 checks passed
@eaudetcobello eaudetcobello deleted the KU-1893/capi-access-handler branch December 11, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschimke95 bschimke95 bschimke95 approved these changes

@HomayoonAlimohammadi HomayoonAlimohammadi HomayoonAlimohammadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eaudetcobello @HomayoonAlimohammadi @bschimke95