Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.31] Fix install by revision in integration tests (#865) #866

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[Backport 1.31] Fix install by revision in integration tests (#865) #866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/integration/tests/test_util/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,9 @@ def setup_k8s_snap(
snap_path = (tmp_path / "k8s.snap").as_posix()
instance.send_file(which_snap, snap_path)
cmd += ["--dangerous", snap_path]
elif snap_revision := _as_int(which_snap):
elif _as_int(which_snap):
LOG.info("Install k8s snap by revision")
cmd += [config.SNAP_NAME, "--revision", snap_revision]
cmd += [config.SNAP_NAME, "--revision", which_snap]
HomayoonAlimohammadi marked this conversation as resolved.
Show resolved Hide resolved
elif "/" in which_snap or which_snap in RISKS:
LOG.info("Install k8s snap by specific channel: %s", which_snap)
cmd += [config.SNAP_NAME, "--channel", which_snap]
Expand Down
Loading