Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cilium ingress, Refactor string literals #848

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fix cilium ingress, Refactor string literals #848

merged 1 commit into from
Nov 27, 2024

Conversation

HomayoonAlimohammadi
Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi commented Nov 27, 2024 •
edited
Loading

@HomayoonAlimohammadi HomayoonAlimohammadi requested a review from a team as a code owner November 27, 2024 10:51
@HomayoonAlimohammadi HomayoonAlimohammadi mentioned this pull request Nov 27, 2024
Merged
bschimke95
bschimke95 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great stuff @HomayoonAlimohammadi

@bschimke95 bschimke95 merged commit b652f3d into main Nov 27, 2024
18 checks passed
@bschimke95 bschimke95 deleted the KU-2219/fix-cilium-ingress-values branch November 27, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschimke95 bschimke95 bschimke95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HomayoonAlimohammadi @bschimke95