Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs page for IPv6-only #756

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Add docs page for IPv6-only #756

merged 4 commits into from
Oct 24, 2024

Conversation

bschimke95
Copy link
Contributor

This is quite similar to the dualstack documentation setup.

@bschimke95 bschimke95 requested a review from a team as a code owner October 22, 2024 10:00
Copy link
Contributor

Hi, looks like pyspelling job found some issues, you can check it here

Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @bschimke95! Great work! LGTM

Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Ben, left a couple of comments!

docs/src/snap/howto/networking/ipv6.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/ipv6.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/ipv6.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/ipv6.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/ipv6.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/ipv6.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/ipv6.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/ipv6.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/ipv6.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/ipv6.md Outdated Show resolved Hide resolved
Co-authored-by: Louise K. Schmidtgen <[email protected]>
Copy link
Contributor

Hi, looks like pyspelling job found some issues, you can check it here

Copy link
Contributor

Hi, looks like pyspelling job found some issues, you can check it here

Copy link
Contributor

@eaudetcobello eaudetcobello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits, then we are good to merge. Thanks Ben!

docs/src/snap/howto/networking/ipv6.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/ipv6.md Outdated Show resolved Hide resolved
docs/src/snap/howto/networking/ipv6.md Outdated Show resolved Hide resolved
Co-authored-by: Louise K. Schmidtgen <[email protected]>
Copy link
Contributor

Hi, looks like pyspelling job found some issues, you can check it here

@bschimke95 bschimke95 merged commit 4469973 into main Oct 24, 2024
6 checks passed
@bschimke95 bschimke95 deleted the KU-1871/IPv6-only-docs branch October 24, 2024 11:39
evilnick pushed a commit to evilnick/k8s-snap that referenced this pull request Nov 14, 2024
---------

Co-authored-by: Louise K. Schmidtgen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants