Strict interfaces test #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
reviewed
Oct 18, 2024
.github/workflows/nightly-test.yaml
Outdated
| os: ["ubuntu:20.04"] | ||
| arch: ["amd64", "arm64"] | ||
| release: ["1.31/edge", "1.30/edge"] | ||
| fail-fast: false # TODO: remove once arm64 works |
There was a problem hiding this comment.
this should work now, right @addyess ?
.github/workflows/nightly-test.yaml
Outdated
| matrix: | ||
| os: ["ubuntu:20.04"] | ||
| arch: ["amd64", "arm64"] | ||
| release: ["1.31/edge", "1.30/edge"] |
There was a problem hiding this comment.
This will not be maintainable.
Please do something like this:
https://github.com/canonical/k8s-snap/blob/main/.github/workflows/nightly-test.yaml#L47
so that the channels are dynamically obtained:
https://github.com/canonical/k8s-snap/blob/main/tests/integration/tests/test_version_upgrades.py#L23
Bonus points if you refactor this logic into a reusable function.
There was a problem hiding this comment.
Baking this into Python, then we can integrate this nicely in the integration test like your version upgrades.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strict interfaces test
This test verifies that the snap store has auto-connected all necessary interfaces for our strict snap in a nightly test on our strict/edge snaps.