-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CIDR for microcluster Network Interface Configuration #449
Conversation
Test with CIDR and ports:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, almost there!
d104f2f
to
4d83456
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a final change and this should be good to go! Nice work @mateoflorido !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final note on style, then we're good to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Mateo! Only add some minor unittests for the new util function and we are good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nicely done!
Allow the user to provide an address, CIDR and/or a port using the `--address` flag in the bootstrap and join commands.
Overview
Infer the address for the microcluster by specifying a CIDR in the address flag.
Rationale
This allows us to have configuration in the ClusterAPI resources (where individual node IPs are not known yet) to choose the network interface that will be used by microcluster.
Testing
Bootstrapping
Joining
microcluster running on the specified CIDR: