Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node address port fixes #284

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Node address port fixes #284

merged 3 commits into from
Apr 3, 2024

Conversation

neoaggelos
Copy link
Contributor

Summary

Fixes around the node microcluster address and port

Changes

  • Remove ListenPort config from the microcluster app configuration, and deprecate the --port k8sd argument. This port is the default HTTPS port for the microcluster app, before the node is bootstrapped. After bootstrapping, this is unused, and the node address specified is used instead.
  • Automatically add the default port (6400), if only the node address is specified during bootstrap (e.g. via k8s bootstrap --address 1.1.1.1)

@neoaggelos neoaggelos requested a review from a team as a code owner April 2, 2024 13:32
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Package Line Rate
github.com/canonical/k8s/api/v1 48%
github.com/canonical/k8s/cmd/k8s 27%
github.com/canonical/k8s/cmd/util 14%
github.com/canonical/k8s/pkg/client/dqlite 44%
github.com/canonical/k8s/pkg/component 9%
github.com/canonical/k8s/pkg/k8sd/api 2%
github.com/canonical/k8s/pkg/k8sd/controllers 67%
github.com/canonical/k8s/pkg/k8sd/database 48%
github.com/canonical/k8s/pkg/k8sd/pki 55%
github.com/canonical/k8s/pkg/k8sd/setup 70%
github.com/canonical/k8s/pkg/k8sd/types 62%
github.com/canonical/k8s/pkg/proxy 6%
github.com/canonical/k8s/pkg/snap 14%
github.com/canonical/k8s/pkg/snap/util 90%
github.com/canonical/k8s/pkg/utils 31%
github.com/canonical/k8s/pkg/utils/control 61%
github.com/canonical/k8s/pkg/utils/errors 100%
github.com/canonical/k8s/pkg/utils/k8s 69%
Summary 32% (1702 / 5345)

Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neoaggelos neoaggelos merged commit a0d2ea4 into main Apr 3, 2024
13 checks passed
@neoaggelos neoaggelos deleted the KU-537/listen-port branch April 3, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants