Skip to content

Commit

Permalink
minor fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
louiseschmidtgen committed Jun 5, 2024
1 parent cafb944 commit 022a454
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 10 deletions.
5 changes: 3 additions & 2 deletions docs/src/snap/howto/networking/default-network.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ sudo k8s kubectl exec -it cilium-97vcw -n kube-system -c cilium-agent \
-- cilium status
```

You should see a wide range of metrics and configuration values for your cluster.
You should see a wide range of metrics and configuration values for your
cluster.

## Disable Network

Expand All @@ -75,7 +76,7 @@ You can `disable` the built-in network:
disabling Network.
```

If you currently have gateway enabled run `sudo k8s disable gateway`
If your underlying network is cilium you will have to run `sudo k8s disable gateway`

Check failure on line 79 in docs/src/snap/howto/networking/default-network.md

View workflow job for this annotation

GitHub Actions / markdown-lint

Line length

docs/src/snap/howto/networking/default-network.md:79:81 MD013/line-length Line length [Expected: 80; Actual: 85] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md013.md

Check failure on line 79 in docs/src/snap/howto/networking/default-network.md

View workflow job for this annotation

GitHub Actions / markdown-lint

Line length

docs/src/snap/howto/networking/default-network.md:79:81 MD013/line-length Line length [Expected: 80; Actual: 85] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md013.md
before disabling network.

```
Expand Down
4 changes: 2 additions & 2 deletions src/k8s/pkg/k8sd/features/contour/gateway.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,14 @@ func ApplyGateway(ctx context.Context, snap snap.Snap, gateway types.Gateway, ne
}
changed, err := m.Apply(ctx, chartContour, helm.StateUpgradeOnlyOrDeleted(network.GetEnabled()), values)
if err != nil {
return fmt.Errorf("failed to apply Gateway API cilium configuration: %w", err)
return fmt.Errorf("failed to apply Gateway API contour configuration: %w", err)
}

if !changed || !gateway.GetEnabled() {
return nil
}
if err := rolloutRestartContour(ctx, snap, 3); err != nil {
return fmt.Errorf("failed to rollout restart cilium to apply Gateway API: %w", err)
return fmt.Errorf("failed to rollout restart contour to apply Gateway API: %w", err)
}

return nil
Expand Down
6 changes: 0 additions & 6 deletions src/k8s/pkg/k8sd/features/contour/ingress.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,6 @@ func ApplyIngress(ctx context.Context, snap snap.Snap, ingress types.Ingress, ne
"tls": map[string]any{
"envoy-client-certificate": ingress.GetDefaultTLSSecret(), //TODO: I think this is wrong
},
"gateway": map[string]any{
"gatewayRef": map[string]any{
"name": "gateway",
"namespace": "project-contour",
},
},
}
}

Expand Down

0 comments on commit 022a454

Please sign in to comment.