IAM 776 Implement validation for all handlers #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarcoMasile
changed the title
BarcoMasile
force-pushed
the
IAM-776-cover-remaining-handlers
branch
from
4ba5edb to
6a17785
Compare
shipperizer
previously approved these changes
Apr 18, 2024
BarcoMasile
force-pushed
the
IAM-776-cover-remaining-handlers
branch
2 times, most recently
from
10a0dbd to
ab4c1c0
Compare
I mistakenly dropped this change in my previous PR 275
BarcoMasile
force-pushed
the
IAM-776-cover-remaining-handlers
branch
from
5b8548a to
7e58651
Compare
shipperizer
approved these changes
Apr 19, 2024
|
closes #228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements validation for remaining APIs, and add tests for all of them.
It also improves previously added tests from #275 .
It also enables validation (basically reverting the changes from #278 ), while also renaming the variable to something more explicit.
Added comments on validation tags to be explicit about what validation is performed.