Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve identity provider forms in UI #249

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Mar 26, 2024

Done

  • improve identity provider forms:
    • add subheadings
    • add help texts
    • improve layout
    • improve visual structure
    • add nice visual for selecting auto discovery / manual urls
  • make buttons in side panels sticky on the bottom
  • avoid react imports

Screenshots

Screenshot from 2024-03-26 16-13-58
Screenshot from 2024-03-26 16-14-11
Screenshot from 2024-03-26 16-14-18

@edlerd edlerd requested a review from a team as a code owner March 26, 2024 15:14
@edlerd edlerd force-pushed the improve-idp-forms branch 3 times, most recently from 51719e5 to 7793f9a Compare March 26, 2024 15:20
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.64%. Comparing base (d2cb05f) to head (b9748ee).
Report is 45 commits behind head on main.

❗ Current head b9748ee differs from pull request most recent head a4acd46. Consider uploading reports for the commit a4acd46 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
+ Coverage   73.14%   74.64%   +1.50%     
==========================================
  Files          29       33       +4     
  Lines        2528     3281     +753     
==========================================
+ Hits         1849     2449     +600     
- Misses        558      691     +133     
- Partials      121      141      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edlerd edlerd force-pushed the improve-idp-forms branch from af0dd68 to b9748ee Compare March 27, 2024 09:37
@shipperizer shipperizer enabled auto-merge March 27, 2024 15:19
edlerd added 2 commits March 27, 2024 16:23
…bottom, better structure on the form with subheadings WD-9957

Signed-off-by: David Edler <[email protected]>
@edlerd edlerd force-pushed the improve-idp-forms branch from c6d5dad to a4acd46 Compare March 27, 2024 15:23
@shipperizer shipperizer merged commit 76eb985 into canonical:main Mar 27, 2024
6 checks passed
@edlerd edlerd deleted the improve-idp-forms branch March 27, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants