Loki config missing if VM running juju and microk8s is restarted or pod is deleted #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pebble_ready event is not fired yet.
sed-i
reviewed
Feb 3, 2022
There was a problem hiding this comment.
I'm surprised the pod deletion scenario wasn't picked up by the itest
https://github.com/canonical/grafana-agent-k8s-operator/blob/main/tests/integration/test_kubectl_delete.py
Mind giving it a look so it captures it?
dstathis
requested changes
Feb 3, 2022
sed-i
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #34.
There are 2 way to test this PR:
Restart VM
lokisectionlokisectionDelete POD
lokisectionmicrok8s.kubectl delete pods grafana-agent-k8s-0 -n observabilitylokisection