Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass 'c_limit' param to hi_def URL #63

Merged
merged 2 commits into from
Jan 7, 2025
Merged

fix: Pass 'c_limit' param to hi_def URL #63

merged 2 commits into from
Jan 7, 2025

Conversation

petesfrench
Copy link
Contributor

@petesfrench petesfrench commented Dec 19, 2024

Done

  • Adds the 'c_limit' flag to the image width and height on hi-def image which limits the max width and height of the image to it's intrinsic width and height, see docs. This is because the hi-def tag doubles the width and height, sometimes leading to the image size being set larger than the original image size, and making the quality worse

QA

  • Open the demo I set up on c.com that references this branch in it's requirements
  • Compare the image quality to production and see they are the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants