-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRD overview resizing fix #4781
Conversation
@philippfromme could you have a look on Windows? |
This comment was marked as outdated.
This comment was marked as outdated.
It still flickers for a bit. But why does it work for the panels, but not for the overview? Do we have competing implementations? Screen.Recording.2025-01-08.at.17.33.23.mov |
The panels are using |
It seems our I had a brief look at how resizing is implemented in the panels and columns of DMN tables. They are both built without utilizing HTML Drag and Drop API. I think HTML dragging is not the best choice to build a resizable container, but rewriting it would have minimal benefit for UX. I suggest we merge this small improvement and leave this topic for now. If you want to leave it untouched until somebody comes to give it a proper re-work, fine by me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK let's accept the state as is. The PR is already an improvement, even though it's not the perfect solution.
I agee, we are using it mainly for historical reasons because this utility has been around for a long time. For the resizable panels (e.g. properties panel) we're not using it anymore. |
Proposed Changes
This pull requests fixes two problems I found when resizing DRD preview:
Before:
Screen.Recording.2025-01-08.at.14.39.34.mov
After:
Screen.Recording.2025-01-08.at.14.40.03.mov
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}