[Profiling] Small adjustments and improved timeline view #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…themselves are activE
…vide scaled flame graphs by 1000
ekiwi
reviewed
Jan 8, 2025
fud2/scripts/profiler.rhai
Outdated
| @@ -40,7 +39,7 @@ fn calyx_to_flamegraph(e, input, output) { | |||
| e.build_cmd(["$cells"], "component-cells", [input], []); | |||
| e.build_cmd([instrumented_verilog], "calyx", [input], []); | |||
| e.arg("backend", "verilog"); | |||
| e.arg("args", " -p static-inline -p compile-static -p compile-repeat -p compile-invoke -p profiler-instrumentation -p $passes -x tdcc:dump-fsm-json=fsm.json"); | |||
| e.arg("args", "-p profiler"); | |||
There was a problem hiding this comment.
let's undo this change so that people can set custom passes
ekiwi
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a series of minor changes I made over the past couple of weeks.
I made some small changes to non-profiler parts of the repo:
*.svgand*.foldedto the gitignore-p profiler)-p profilerin fud2 so there's no inconsistency in what passes we use.In profiler-specific code, I fixed a bug where the flame graph recorded one extra cycle for
main, added colors to categorize nodes in the aggregate tree picture (between cells, groups, and primitives), and have the profiler emit a timeline JSON involving all cells by default.