Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:UI_Improved_of_Delete_Workflow_Button_and_Calender_Part #18879

Closed
wants to merge 7 commits into from
Closed

feat:UI_Improved_of_Delete_Workflow_Button_and_Calender_Part #18879

wants to merge 7 commits into from

Conversation

Jynx2004
Copy link

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel Vercel
Copy link

vercel bot commented Jan 24, 2025

@Jynx2004 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 24, 2025
@graphite-app graphite-app bot requested a review from a team January 24, 2025 19:51
@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Jan 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "feat:UI_Improved_of_Delete_Workflow_Button_and_Calender_Part". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Jan 24, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 24, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/24/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/24/25)

1 label was added to this PR based on Keith Williams's automation.

@Praashh Praashh changed the title UI_Improved_of_Delete_Workflow_Button_and_Calender_Part feat:UI_Improved_of_Delete_Workflow_Button_and_Calender_Part Jan 25, 2025
Praashh
Praashh reviewed Jan 25, 2025
View reviewed changes
packages/features/calendars/DatePicker.tsx Outdated
Comment on lines 125 to 127
{/* <Button onClick={nextMonthButton} color="primary" EndIcon="arrow-right" data-testid="view_next_month">
{t("view_next_month")}
</Button>
</Button> */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we commenting this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are not allowing the user to book too far , so due to that thing , i have removed the button which on clicking displays the next month .

Praashh
Praashh requested changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments

Praashh
Praashh reviewed Jan 25, 2025
View reviewed changes
.env.appStore.example Outdated
@@ -142,3 +142,4 @@ REVERT_API_URL=https://api.revert.dev/
# - Huddle01
# Used for the huddle01 integration
HUDDLE01_API_TOKEN=

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya i will remove this . Sorry for that

Jynx2004
Jynx2004 commented Jan 25, 2025
View reviewed changes
Copy link
Author

@Jynx2004 Jynx2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes done

@Praashh
Copy link
Contributor

Praashh commented Jan 25, 2025

Hey @Jynx2004, thank you for the PR, closing it for now, feel free to make for other issues.

@Praashh Praashh closed this Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praashh Praashh Praashh requested changes

Assignees
No one assigned
Labels
community Created by Linear-GitHub Sync ❗️ .env changes contains changes to env variables 🧹 Improvements Improvements to existing features. Mostly UX/UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jynx2004 @Praashh