Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: attendee dropdown is now clearly visible #18811

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: attendee dropdown is now clearly visible #18811

wants to merge 6 commits into from

Conversation

retrogtx
Copy link
Contributor

@retrogtx retrogtx commented Jan 22, 2025 •
edited
Loading

What does this PR do?

Attendee dropdown was not visible previously, so this PR fixes that.
Imported an already present component DropdownMenuPortal and adjusted the code accordingly for the booking page.

https://www.loom.com/share/a544ff5f664a472ab6fffd96de830b8d?sid=ecc450f8-4be6-4043-ae74-a77f7a0b1389

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 22, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 22, 2025

@retrogtx is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team January 22, 2025 16:01
@github-actions github-actions bot added bookings area: bookings, availability, timezones, double booking ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels Jan 22, 2025
@dosubot dosubot bot added the booking-page area: booking page, public booking page, booker label Jan 22, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 22, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/22/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/22/25)

1 label was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

E2E results are ready!

Praashh
Praashh previously approved these changes Jan 23, 2025
View reviewed changes
@retrogtx
Copy link
Contributor Author

I suppose you guys have taken over, is there something else I must do?

@PeerRich @sean-brydon

@Praashh
Copy link
Contributor

Praashh commented Jan 25, 2025 •
edited
Loading

I suppose you guys have taken over, is there something else I must do?

@PeerRich @sean-brydon

Hey @retrogtx, E2E tests are failing, can you fix it?

@retrogtx
Copy link
Contributor Author

looks like doing a force push dismissed your review, didn't mean to do that 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praashh Praashh Praashh left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
booking-page area: booking page, public booking page, booker bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync ready-for-e2e ui area: UI, frontend, button, form, input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attendee dropdown is transparent in bookings list
4 participants
@retrogtx @Praashh @sean-brydon @PeerRich