fix: Default people filter in bookings list for admin #18035

vijayraghav-io · 2024-12-06T05:52:07Z

What does this PR do?

Fixes [CAL-4851] If you're an admin, automatically filter to show your own bookings #18026
Fixes CAL-4851

https://www.loom.com/share/dea5233306dd436c8e0e974c9dd658f5?sid=074ec548-12f4-47ae-8060-2d1497d99785

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
- N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

vercel · 2024-12-06T05:52:12Z

@vijayraghav-io is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2024-12-06T05:52:17Z

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Default people filter in bookings list for admin". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

graphite-app · 2024-12-06T05:55:11Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/06/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/06/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/08/24)

1 label was added to this PR based on Keith Williams's automation.

vercel · 2024-12-06T06:37:13Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cal	❌ Failed (Inspect)			Dec 11, 2024 7:53am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		Dec 11, 2024 7:53am

Praashh

Would be better, if you have test case for this functionality. @vijayraghav-io can you please add ?

vijayraghav-io · 2024-12-06T12:09:37Z

Would be better, if you have test case for this functionality. @vijayraghav-io can you please add ?

sure will add

apps/web/modules/bookings/views/bookings-listing-view.tsx

vijayraghav-io · 2024-12-07T19:25:09Z

@Praashh , added an e2e test

Praashh

Great Work @vijayraghav-io.

github-actions · 2024-12-08T06:14:13Z

E2E results are ready!

Workflow #45325.1 latest results

vijayraghav-io · 2024-12-08T09:11:13Z

Verified multiple times locally the new test is passing, along with bookings-list.e2e module.
Will figure out and update to remove flakiness on server.

…inAutoFilterBookings

vijayraghav-io · 2024-12-09T07:22:04Z

@Praashh all tests are passing

Praashh

Awesome work.

vijayraghav-io · 2024-12-09T11:42:44Z

Thanks @Praashh may be you have to approve again, as prev approve was staled

…inAutoFilterBookings

github-actions · 2024-12-26T00:21:40Z

This PR is being marked as stale due to inactivity.

…inAutoFilterBookings

vijayraghav-io · 2024-12-27T07:52:16Z

Gentle Reminder for review / action.

Praashh · 2024-12-27T14:16:29Z

Gentle Reminder for review / action.

Cool Sir, I'll give it final touch 🙏 .

vijayraghav-io · 2024-12-27T14:19:02Z

sure Thank you! 🙏

Praashh

LGTM ❤️ !!

vijayraghav-io · 2025-01-01T12:39:12Z

Gentle Reminder!

PeerRich · 2025-01-14T16:07:54Z

hey @vijayraghav-io can you check the merge conflict?

…inAutoFilterBookings

vijayraghav-io · 2025-01-14T17:37:30Z

hey @vijayraghav-io can you check the merge conflict?

@PeerRich , resolved merge conflicts 🙏

PeerRich

approved on behalf of @Praashh

…inAutoFilterBookings

vijayraghav-io · 2025-01-26T15:24:16Z

resolved merge conflicts

default people filter for admin

61a2a77

graphite-app bot added the community Created by Linear-GitHub Sync label Dec 6, 2024

graphite-app bot requested a review from a team December 6, 2024 05:52

github-actions bot added Low priority Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Dec 6, 2024

dosubot bot added the bookings area: bookings, availability, timezones, double booking label Dec 6, 2024

vercel bot deployed to Preview – api December 6, 2024 06:01 View deployment

vijayraghav-io changed the title ~~Default people filter in bookings list for admin~~ fix: Default people filter in bookings list for admin Dec 6, 2024

chore

39d8695

vercel bot had a problem deploying to Preview – cal December 6, 2024 06:37 Failure

vercel bot deployed to Preview – api December 6, 2024 06:45 View deployment

type check

9234b61

vercel bot had a problem deploying to Preview – cal December 6, 2024 06:52 Failure

vercel bot had a problem deploying to Preview – dev December 6, 2024 06:52 Failure

vercel bot deployed to Preview – api December 6, 2024 06:59 View deployment

Praashh requested changes Dec 6, 2024

View reviewed changes

youneshenniwrites reviewed Dec 6, 2024

View reviewed changes

apps/web/modules/bookings/views/bookings-listing-view.tsx Show resolved Hide resolved

added test case

441f11a

vercel bot deployed to Preview – api December 7, 2024 19:27 View deployment

Praashh previously approved these changes Dec 8, 2024

View reviewed changes

graphite-app bot added the ready-for-e2e label Dec 8, 2024

made test concise to reduce flakiness

9eb53eb

vijayraghav-io dismissed Praashh’s stale review via 9eb53eb December 8, 2024 08:03

vercel bot deployed to Preview – api December 8, 2024 08:50 View deployment

vijayraghav-io added 2 commits December 9, 2024 11:17

Merge branch 'main' of https://github.com/calcom/cal.com into fix_adm…

f3b6439

…inAutoFilterBookings

update timeout

c5ec249

vercel bot deployed to Preview – api December 9, 2024 06:38 View deployment

Praashh reviewed Dec 9, 2024

View reviewed changes

Merge branch 'main' of https://github.com/calcom/cal.com into fix_adm…

27268f4

…inAutoFilterBookings

vercel bot had a problem deploying to Preview – cal December 11, 2024 07:53 Failure

vercel bot had a problem deploying to Preview – dev December 11, 2024 07:53 Failure

vercel bot deployed to Preview – api December 11, 2024 08:01 View deployment

github-actions bot added the Stale label Dec 26, 2024

Merge branch 'main' of https://github.com/calcom/cal.com into fix_adm…

31af3e9

…inAutoFilterBookings

github-actions bot removed the Stale label Dec 28, 2024

Praashh previously approved these changes Dec 28, 2024

View reviewed changes

Merge branch 'main' of https://github.com/calcom/cal.com into fix_adm…

22c17c2

…inAutoFilterBookings

vijayraghav-io dismissed Praashh’s stale review via 22c17c2 January 14, 2025 17:35

Merge branch 'main' into fix_adminAutoFilterBookings

fe19c27

PeerRich previously approved these changes Jan 15, 2025

View reviewed changes

Merge branch 'main' of https://github.com/calcom/cal.com into fix_adm…

20b4caf

…inAutoFilterBookings

vijayraghav-io dismissed PeerRich’s stale review via 20b4caf January 26, 2025 15:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Default people filter in bookings list for admin #18035

fix: Default people filter in bookings list for admin #18035

vijayraghav-io commented Dec 6, 2024 •

edited

Loading

vercel bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

graphite-app bot commented Dec 6, 2024 •

edited

Loading

vercel bot commented Dec 6, 2024 •

edited

Loading

Praashh left a comment

vijayraghav-io commented Dec 6, 2024

vijayraghav-io commented Dec 7, 2024

Praashh left a comment

github-actions bot commented Dec 8, 2024 •

edited

Loading

vijayraghav-io commented Dec 8, 2024

vijayraghav-io commented Dec 9, 2024

Praashh left a comment

vijayraghav-io commented Dec 9, 2024

github-actions bot commented Dec 26, 2024

vijayraghav-io commented Dec 27, 2024 •

edited

Loading

Praashh commented Dec 27, 2024

vijayraghav-io commented Dec 27, 2024

Praashh left a comment

vijayraghav-io commented Jan 1, 2025

PeerRich commented Jan 14, 2025

vijayraghav-io commented Jan 14, 2025 •

edited

Loading

PeerRich left a comment

vijayraghav-io commented Jan 26, 2025

fix: Default people filter in bookings list for admin #18035

Are you sure you want to change the base?

fix: Default people filter in bookings list for admin #18035

Conversation

vijayraghav-io commented Dec 6, 2024 • edited Loading

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

vercel bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

graphite-app bot commented Dec 6, 2024 • edited Loading

Graphite Automations

vercel bot commented Dec 6, 2024 • edited Loading

Praashh left a comment

Choose a reason for hiding this comment

vijayraghav-io commented Dec 6, 2024

vijayraghav-io commented Dec 7, 2024

Praashh left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 8, 2024 • edited Loading

E2E results are ready!

vijayraghav-io commented Dec 8, 2024

vijayraghav-io commented Dec 9, 2024

Praashh left a comment

Choose a reason for hiding this comment

vijayraghav-io commented Dec 9, 2024

github-actions bot commented Dec 26, 2024

vijayraghav-io commented Dec 27, 2024 • edited Loading

Praashh commented Dec 27, 2024

vijayraghav-io commented Dec 27, 2024

Praashh left a comment

Choose a reason for hiding this comment

vijayraghav-io commented Jan 1, 2025

PeerRich commented Jan 14, 2025

vijayraghav-io commented Jan 14, 2025 • edited Loading

PeerRich left a comment

Choose a reason for hiding this comment

vijayraghav-io commented Jan 26, 2025

vijayraghav-io commented Dec 6, 2024 •

edited

Loading

graphite-app bot commented Dec 6, 2024 •

edited

Loading

vercel bot commented Dec 6, 2024 •

edited

Loading

github-actions bot commented Dec 8, 2024 •

edited

Loading

vijayraghav-io commented Dec 27, 2024 •

edited

Loading

vijayraghav-io commented Jan 14, 2025 •

edited

Loading