-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make weeksOfMonthByDay match weeks from the end of the month too #53
base: master
Are you sure you want to change the base?
Conversation
Hi cesarizu, I have created a plunkr to illustrate the issue: http://plnkr.co/edit/GUvwbFLAXXwKcGpucP3D?p=preview (Just exchange the scripts in the head of index.html to see the difference) |
This is the exact use case I'm interested in - for example the 'last Sunday' of each month from start date to end date. @cesarizu Would love to see a resolve to @Jean-Rashmir 's issue so this can be integrated! Thanks for the great work! |
b5730f0
to
8cae2c4
Compare
@Jean-Rashmir and @rmckeel thanks for your comments. If you use this PR's branch:
EDIT: I've fix the other PR, so master is working for the plunkr just fine now. |
I tested locally with the PR's code yesterday, and it worked exactly as desired, fitting the test cases I could think of and keeping the existing functionality I had built with the official branch. |
8cae2c4
to
cca5518
Compare
@c-trimm I've rebased this branch to the latest master, is there anything else missing or anything you'd like me to do to merge this? |
Any update here? This is a core bug otherwise |
Bump |
This PR allows the testing against the week of the month by day from the end of the month, for example the last Friday of the month. This is achieved by passing a negative number to the
weeksOfMonthByDay
matcher.