Add wholeMonths interval to weeksOfMonthByDay #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an addition to the closed issue c-trimm#10, the wholeMonths interval adds the ability to choose every nth months to the weeksOfMonthByDay interval.
| @@ -27,8 +27,12 @@ | |||
| } | |||
| } | |||
|
|
|||
| if (measure !== 'wholeMonths') { | |||
There was a problem hiding this comment.
This indentation seems wrong.
|
Looks great. Please do a bit of reorganization. |
Created a function to calculate the diff for intervals. Created a validateRule method that is used when trying to set a rule. Removed .toLowerCase() method when creating an interval. Fixed indentation issue.
Changed wholeMonth to wholeMonths.
Use subtraction instead of difference to calculate wholeMonths. For this purpose difference sometimes returns inaccurate values since it rounds the number down.
|
Yes wholeMonths can work with daysOfMonth. The Validate rule for
wholeMonths will have to be removed or altered to also check for
daysOfMonth. An example is: moment(startDate).recur().every([5,
10]).daysOfMonth().every(2).wholeMonths().
…On Fri, Mar 16, 2018 at 11:06 AM Alex Bross ***@***.***> wrote:
This works well for weeksOfMonthByDay. Is there any way to get wholeMonths
to work with daysOfMonth, as well? For example to choose the 5th and 10th
days of every other month.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC1ZvoCdKc02bOCn7JE3fhORzalaO_tMks5te-MegaJpZM4HAxMG>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an addition to the closed issue #10, the wholeMonths interval adds
the ability to choose every nth months to the weeksOfMonthByDay
interval.