add support for secret types #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzon
requested changes
Apr 8, 2019
| @@ -42,9 +42,10 @@ func main() { | |||
| interval := flag.Int("interval", 1200, "Refresh interval in seconds") | |||
| profile := flag.String("profile", "", "The AWS Account profile") | |||
| secretName := flag.String("secretName", "ecr-auth-cfg", "The name of the secret") | |||
| secretType := flag.String("secretType", "Opaque", "The secret type to store") | |||
There was a problem hiding this comment.
Can we provide the valid options in the description?
| @@ -42,9 +42,10 @@ func main() { | |||
| interval := flag.Int("interval", 1200, "Refresh interval in seconds") | |||
| profile := flag.String("profile", "", "The AWS Account profile") | |||
| secretName := flag.String("secretName", "ecr-auth-cfg", "The name of the secret") | |||
| secretType := flag.String("secretType", "Opaque", "The secret type to store") | |||
| flag.Parse() | |||
There was a problem hiding this comment.
Please also do type assertion or validation after parsing the flags.
|
@phmayer67 thanks for the PR. I would be nice if you can add a section in the documentation for this as well. |
|
Any chance on getting that finished/merged? It would be quite useful for me, and I'd prefer to avoid keeping a fork. Can help with this PR |
|
@kowalczykp I think this PR is dead... Feel free to create a new PR. Thanks. |
|
cool, will do so 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for docker secret types