Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove generating the BuildConfig on Android modules #57

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Remove generating the BuildConfig on Android modules #57

merged 1 commit into from
Sep 29, 2022

Conversation

5peak2me
Copy link

@5peak2me 5peak2me commented Sep 29, 2022 •
edited
Loading

This PR Remove generating the BuildConfig on bytehook module.

caikelun
caikelun reviewed Sep 29, 2022
View reviewed changes
Copy link
Member

@caikelun caikelun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bytehook only has a small amount of java code. We do not use annotation, in order to reduce the compatibility problems when APP integration.

caikelun
caikelun requested changes Sep 29, 2022
View reviewed changes
Copy link
Member

@caikelun caikelun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please put these two unrelated commits in different PRs.
The commit that modify the buildConfig will be merged, and the commit that add annotation are not considered merged at present.

@caikelun caikelun merged commit 0d1f7a9 into bytedance:dev Sep 29, 2022
@caikelun
Copy link
Member

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caikelun caikelun caikelun requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@5peak2me @caikelun