Skip to content

Commit

Permalink
Update release notes and fix issues reported by Coverity (#1813)
Browse files Browse the repository at this point in the history
  • Loading branch information
wenyongh authored Dec 16, 2022
1 parent d0c4c70 commit fb8727b
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build_docker_images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
docker build -t wasm-debug-server:${{ inputs.ver_num }} .
docker save -o wasm-debug-server.tar wasm-debug-server:${{ inputs.ver_num }}
working-directory: test-tools/wamr-ide/WASM-Debug-Server/Docker

- name: compress the tar file
run: |
tar czf wasm-debug-server-${{ inputs.ver_num }}.tar.gz wasm-debug-server.tar
Expand Down Expand Up @@ -86,4 +86,4 @@ jobs:
asset_path: test-tools/wamr-ide/WASM-Toolchain/Docker/wasm-toolchain-${{ inputs.ver_num }}.zip
asset_name: wasm-toolchain-${{ inputs.ver_num }}.zip
asset_content_type: application/zip

3 changes: 3 additions & 0 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ Fix sample ref-types/wasm-c-api build error with wat2wasm low version
Fix zephyr sample build errors
Fix source debugger error handling: continue executing when detached
Fix scenario where the timeout for atomic wait is set to negative number
Fix link cxx object file error when building wamrc for docker image
Fix XIP issue of handling 64-bit const in 32-bit target

### Enhancements
Refactor the layout of interpreter and AOT module instance
Expand Down Expand Up @@ -75,6 +77,7 @@ Fix warnings in the posix socket implementation
Update document for MacOS compilation
Install patched LLDB on vscode extension activation
Add ARM aeabi memcpy/memmove/memset symbols for AOT bulk memory ops
Enable wasm cache loading in wasm-c-api

### Others
Add CIs to release new version and publish binary files
Expand Down
4 changes: 2 additions & 2 deletions core/iwasm/libraries/debug-engine/handler.c
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,7 @@ handle_add_break(WASMGDBServer *server, char *payload)
handle_watchpoint_read_add(server, addr, length);
break;
default:
LOG_ERROR("Unsupported breakpoint type %d", type);
LOG_ERROR("Unsupported breakpoint type %zu", type);
write_packet(server, "");
break;
}
Expand Down Expand Up @@ -766,7 +766,7 @@ handle_remove_break(WASMGDBServer *server, char *payload)
handle_watchpoint_read_remove(server, addr, length);
break;
default:
LOG_ERROR("Unsupported breakpoint type %d", type);
LOG_ERROR("Unsupported breakpoint type %zu", type);
write_packet(server, "");
break;
}
Expand Down
8 changes: 4 additions & 4 deletions test-tools/wamr-ide/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ From now on, for each release, we have the same version tagged docker image save
You could download the tar archive files for docker images from the release, and then load them using the following commands:

```sh
# download the zip or tar.gz from release depending on your platform
# download the zip or tar.gz from release depending on your platform
# decompress and get the tar file

# on Linux/MacOS, you could use tar
Expand All @@ -55,14 +55,14 @@ tar xf wasm-debug-server-{version number}.tar.gz
# or you could use unzip
unzip wasm-toolchain-{version number}.zip
unzip wasm-debug-server-{version number}.zip
# load wasm-toolchain
# load wasm-toolchain
docker load --input wasm-toolchain.tar
# load wasm-debug-server
docker load --input wasm-debug-server.tar

# on Windows, you could use any unzip software you like
# on Windows, you could use any unzip software you like
# then loading docker images using powershell or git bash
# load wasm-toolchain
# load wasm-toolchain
docker load --input ./wasm-toolchain.tar
# load wasm-debug-server
docker load --input ./wasm-debug-server.tar
Expand Down

0 comments on commit fb8727b

Please sign in to comment.