Fixed default value of merge_type parameter in merge_cells function docstring.

[neolooong]

Fixed default value of merge_type parameter in merge_cells function docstring.

[alifeee]

thanks, this is helpful! I always love a docs change :)

got me thinking, why aren't we using a tuple for this parameter? like for DateTimeOption?

gspread/gspread/utils.py

Lines 41 to 43 in c3b61d0

	DateTimeOption = namedtuple(
	"DateTimeOption", ["serial_number", "formatted_string", "formated_string"]
	)("SERIAL_NUMBER", "FORMATTED_STRING", "FORMATTED_STRING")

perhaps we could change it... @lavigne958 thoughts ?

[lavigne958]

Thanks for the doc update.

I think we missed it 😮
Yep we can upgrade it to a namedtuple but we should make sure people can keep using strings and it works. That I'm not sure 😬 if that does not work we can't change it and should just update the documentation

[neolooong]

I am sure that after changing to namedtuple, people still can use string.

[alifeee]

quick change! it looks good :)

now is probably also the time to add a test for merge_cells (and a merge_type test too), since there is not one in worksheet_test.py

you are welcome to give this a go, or one of us will do it if you would rather not deal with the tests :)

[lavigne958]

thanks for the fix !
I agree if you feel like it, feel free to add a test on merge cells, if not, no worries we'll add them.

Tested it, it works in all bellow cases:

• with sheet.merge_cell("A1:B2", "MERGE_ALL")
• with sheet.merge_cell("A1:B2", gspread.utils.MergeType.merge_all)
  which makes it ISO functional with current code base 👍

[alifeee]

super. we will merge this and add a test for merge_cells in a week or so if there is no more activity here :)

[lavigne958]

Thanks for the new tests !