Prototype with pager #721
Prototype with pager #721
Conversation
…ey/appyx into 1.x-shared-element-prototype
Co-authored-by: Manuel Vivo <[email protected]>
Co-authored-by: Manuel Vivo <[email protected]>
…e/Children.kt Co-authored-by: Manuel Vivo <[email protected]>
Co-authored-by: Manuel Vivo <[email protected]>
- Moved LocalMovableContentMap to Children composable and added a parameter to it. - Added support for more movableContent API variants
…ment-prototype-copy
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,4 @@ | |||
| package com.bumble.appyx.sandbox.client.sharedelement.with_pager | |||
Check warning
Code scanning / detekt
Package names should match the naming convention set in the configuration. Warning
| class ShareElementDetailsNode { | ||
| } |
Check warning
Code scanning / detekt
Empty block of code detected. As they serve no purpose they should be removed. Warning
| package com.bumble.appyx.sandbox.client.sharedelement.with_pager | ||
|
|
||
| class ShareElementDetailsNode { | ||
| } |
Check warning
Code scanning / detekt
Checks whether files end with a line separator. Warning
| @@ -0,0 +1,4 @@ | |||
| package com.bumble.appyx.sandbox.client.sharedelement.with_pager | |||
Check warning
Code scanning / detekt
Package names should match the naming convention set in the configuration. Warning
| class SharedElementPagerNode { | ||
| } |
Check warning
Code scanning / detekt
Empty block of code detected. As they serve no purpose they should be removed. Warning
| package com.bumble.appyx.sandbox.client.sharedelement.with_pager | ||
|
|
||
| class SharedElementPagerNode { | ||
| } |
Check warning
Code scanning / detekt
Checks whether files end with a line separator. Warning
| @@ -0,0 +1,146 @@ | |||
| package com.bumble.appyx.sandbox.client.sharedelement.with_pager | |||
Check warning
Code scanning / detekt
Package names should match the naming convention set in the configuration. Warning
| } | ||
|
|
||
| @OptIn(ExperimentalSharedTransitionApi::class) | ||
| override fun resolve(navTarget: NavTarget, buildContext: BuildContext): Node { |
Check warning
Code scanning / detekt
One method should have one responsibility. Long methods tend to handle many things at once. Prefer smaller methods to make them easier to understand. Warning
| transitionHandler = rememberBackstackFader(transitionSpec = { tween(300) }) | ||
| ) | ||
| } | ||
| } |
Check warning
Code scanning / detekt
Checks whether files end with a line separator. Warning
Won't merge, just showcasing the pager