Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Position implement Parcelable to avoid crash #444

Merged
merged 1 commit into from
May 24, 2023
Merged

Make Position implement Parcelable to avoid crash #444

merged 1 commit into from
May 24, 2023

Conversation

KovalevAndrey
Copy link
Collaborator

@KovalevAndrey KovalevAndrey commented May 24, 2023 •
edited
Loading

Description

Position should implement parcelable to avoid crash when saving state

Check list

  • I have updated CHANGELOG.md if required.
  • I have updated documentation if required.

zsoltk
zsoltk approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@zsoltk zsoltk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw we should enforce this compile-time for all other cases too: #310

@KovalevAndrey KovalevAndrey merged commit 49f851a into bumble-tech:2.x May 24, 2023
@KovalevAndrey KovalevAndrey deleted the 2.x-spotlight-crash-when-saving-state branch May 24, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsoltk zsoltk zsoltk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KovalevAndrey @zsoltk