Merge pull request #6 from bugless/fix-hashcode

Add hashCode implementation
bugless · Sep 27, 2021 · c605e8f · c605e8f
2 parents 07a9f98 + 6cae56b
commit c605e8f
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # CHANGELOG
 
+## 0.3.0
+- Add missing hashCode implementation ~aka remove feature where all BigDecimals were different~
+
 ## 0.2.1
 - Remove undue logs
 

diff --git a/lib/src/big_decimal.dart b/lib/src/big_decimal.dart
@@ -336,6 +336,9 @@ class BigDecimal implements Comparable<BigDecimal> {
     return _add(intVal, -other.intVal, scale, other.scale).intVal.sign;
   }
 
+  @override
+  int get hashCode => 31 * intVal.hashCode + scale;
+
   @override
   String toString() {
     if (scale == 0) {

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: big_decimal
-version: 0.2.1
+version: 0.3.0
 description: >
   A bugless implementation of BigDecimal in Dart based on Java's BigDecimal
 

diff --git a/test/big_decimal_test.dart b/test/big_decimal_test.dart
@@ -428,4 +428,20 @@ void main() {
       tabCase(['123.456e-8', '0.00000123456']),
     ]),
   );
+
+  group('hashcode', () {
+    test('same for equal numbers', () {
+      expect('1.0'.dec.hashCode, '1.0'.dec.hashCode);
+      expect('-1.0'.dec.hashCode, '-1.0'.dec.hashCode);
+      expect('1.0000'.dec.hashCode, '1.0000'.dec.hashCode);
+      expect('0'.dec.hashCode, '0'.dec.hashCode);
+    });
+
+    test('different for different numbers', () {
+      expect(false, '1.0'.dec.hashCode == '1.00'.dec.hashCode);
+      expect(false, '-1.0'.dec.hashCode == '1.0'.dec.hashCode);
+      expect(false, '1.0000'.dec.hashCode == '2'.dec.hashCode);
+      expect(false, '0'.dec.hashCode == '0.00'.dec.hashCode);
+    });
+  });
 }