Fixed _extract_post_id returning null values caused by multiple items in page with class _5pcq #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_extract_post_id
uses the class_5pcq
to get the postId. This sometimes fails when there is a long list of items with that class, some of which have an effectively emptyhref
tag. Propose a fix where we check if thehref
tag contains a URL (beginning with '/') before extracting.Sample list of prints from
item.find_all(class_="_5pcq")
below. The last item on the list has '#' in thehref
field. This causes the resultantpost_id
to be '#'.To replicate:
python scraper.py -p TheStraitsTimes -l 1