Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a single instance of mc ref tracker for all parts of the node #568

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

Rexagon
Copy link
Member

@Rexagon Rexagon commented Jan 25, 2025

We were using a couple of unrelated trackers which caused GC to delete states loaded from the storage despite having alive handles acquired by state applier.

Now we use a single instance of this tracker provided by ShardStateStorage::min_ref_mc_state.

@Rexagon Rexagon requested review from SmaGMan and 0xdeafbeef January 25, 2025 19:45
@Rexagon Rexagon force-pushed the fix/use-signal-ref-seqno-tracker branch from 640f537 to 4653814 Compare January 25, 2025 19:51
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 72.09302% with 12 lines in your changes missing coverage. Please review.

Project coverage is 42.96%. Comparing base (352ec12) to head (4653814).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
block-util/src/state/shard_state_stuff.rs 40.00% 6 Missing ⚠️
core/src/block_strider/starter/cold_boot.rs 0.00% 4 Missing ⚠️
collator/src/test_utils.rs 83.33% 0 Missing and 1 partial ⚠️
core/src/block_strider/state_applier.rs 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
+ Coverage   42.93%   42.96%   +0.03%     
==========================================
  Files         276      276              
  Lines       51033    51019      -14     
  Branches    51033    51019      -14     
==========================================
+ Hits        21910    21922      +12     
+ Misses      28010    27985      -25     
+ Partials     1113     1112       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rexagon Rexagon added this pull request to the merge queue Jan 25, 2025
Merged via the queue into master with commit b151e38 Jan 25, 2025
11 checks passed
@Rexagon Rexagon deleted the fix/use-signal-ref-seqno-tracker branch January 25, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants