Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collator): optimize and fix messages collection for execution #567

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

SmaGMan
Copy link
Contributor

@SmaGMan SmaGMan commented Jan 24, 2025

No description provided.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 6.54762% with 157 lines in your changes missing coverage. Please review.

Project coverage is 42.77%. Comparing base (b151e38) to head (1a57042).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
collator/src/collator/messages_reader/mod.rs 0.00% 79 Missing ⚠️
...r/src/collator/messages_reader/internals_reader.rs 0.00% 44 Missing ⚠️
...r/src/collator/messages_reader/externals_reader.rs 31.25% 21 Missing and 1 partial ⚠️
...lator/src/collator/messages_reader/reader_state.rs 11.11% 8 Missing ⚠️
collator/src/collator/messages_buffer.rs 0.00% 3 Missing ⚠️
collator/src/collator/do_collate/execute.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
- Coverage   42.96%   42.77%   -0.19%     
==========================================
  Files         276      276              
  Lines       51019    51072      +53     
  Branches    51019    51072      +53     
==========================================
- Hits        21918    21848      -70     
- Misses      27988    28107     +119     
- Partials     1113     1117       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SmaGMan SmaGMan force-pushed the feature/finish-prev-externals branch from daf91d5 to d0903f0 Compare January 24, 2025 21:29
@SmaGMan SmaGMan force-pushed the feature/finish-prev-externals branch from d0903f0 to c3871eb Compare January 26, 2025 09:44
@SmaGMan SmaGMan changed the title feat(collator): collect externals from the previous block collation first feat(collator): optimize and fix messages collection for execution Jan 26, 2025
@SmaGMan SmaGMan force-pushed the feature/finish-prev-externals branch from 8ce0a18 to 1a57042 Compare January 26, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant