Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messages processing logic v3 #531

Merged
merged 54 commits into from
Jan 23, 2025
Merged

messages processing logic v3 #531

merged 54 commits into from
Jan 23, 2025

Conversation

SmaGMan
Copy link
Contributor

@SmaGMan SmaGMan commented Jan 9, 2025

No description provided.

@SmaGMan SmaGMan force-pushed the feat/msgs-proc-logic-v3 branch 5 times, most recently from 7f46b38 to 7e3129f Compare January 15, 2025 22:01
@SmaGMan SmaGMan force-pushed the feat/msgs-proc-logic-v3 branch 4 times, most recently from 1078aff to 117f9c4 Compare January 20, 2025 10:02
@drmick drmick force-pushed the feat/msgs-proc-logic-v3 branch from 117f9c4 to 3de01c0 Compare January 20, 2025 10:16
@SmaGMan SmaGMan force-pushed the feat/msgs-proc-logic-v3 branch from f92f6a7 to ac8ae91 Compare January 20, 2025 16:58
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 40.04989% with 3124 lines in your changes missing coverage. Please review.

Project coverage is 42.97%. Comparing base (cf53651) to head (70de435).
Report is 54 commits behind head on master.

Files with missing lines Patch % Lines
collator/src/collator/messages_reader/mod.rs 4.94% 538 Missing ⚠️
...r/src/collator/messages_reader/internals_reader.rs 0.00% 537 Missing ⚠️
...lator/src/collator/messages_reader/new_messages.rs 0.00% 278 Missing ⚠️
collator/src/types/processed_upto.rs 3.55% 188 Missing and 2 partials ⚠️
collator/src/collator/do_collate/mod.rs 27.39% 167 Missing ⚠️
...r/src/collator/messages_reader/externals_reader.rs 68.42% 123 Missing and 27 partials ⚠️
storage/src/store/internal_queue/mod.rs 60.47% 146 Missing and 3 partials ⚠️
...lator/src/collator/messages_reader/reader_state.rs 53.09% 135 Missing and 9 partials ⚠️
collator/src/collator/do_collate/finalize.rs 0.00% 117 Missing ⚠️
collator/src/collator/do_collate/work_units.rs 0.00% 102 Missing ⚠️
... and 34 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
- Coverage   44.23%   42.97%   -1.26%     
==========================================
  Files         270      276       +6     
  Lines       47730    50927    +3197     
  Branches    47730    50927    +3197     
==========================================
+ Hits        21112    21885     +773     
- Misses      25536    27928    +2392     
- Partials     1082     1114      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SmaGMan SmaGMan force-pushed the feat/msgs-proc-logic-v3 branch from 7824644 to 99cfc42 Compare January 21, 2025 17:17
@SmaGMan SmaGMan marked this pull request as ready for review January 21, 2025 17:20
@SmaGMan SmaGMan force-pushed the feat/msgs-proc-logic-v3 branch from 745281b to f569939 Compare January 23, 2025 19:19
drmick and others added 13 commits January 23, 2025 19:41
feat(collator): use diffs tail for sync queue persistent

refactor(collator): rename and refactor structs

refactor(collator): rename internal queue structs

test(collator): add internal queue tail test

refactor(collator): improve internal queue commit performance

refactor(collator): refactor diffs tail and add tests

fix(core): gc range queue diffs tail
ref(collator): change load statistics func
feat(collator): use current block max lt to set read to boundary for new messages
@SmaGMan SmaGMan force-pushed the feat/msgs-proc-logic-v3 branch from b70e051 to 70de435 Compare January 23, 2025 19:42
@Rexagon Rexagon added this pull request to the merge queue Jan 23, 2025
Merged via the queue into master with commit a150a18 Jan 23, 2025
9 of 11 checks passed
@Rexagon Rexagon deleted the feat/msgs-proc-logic-v3 branch January 23, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants