Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SpiderMonkey binaries #36

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

progval
Copy link
Contributor

@progval progval commented Jun 17, 2014

An issue in SpiderMonkey prevented me from running the test262 suite: the output of JSON.stringify just stopped on some unicode characters (which the JSON parser complained about):

vlorentz@gommier:~/js/LambdaS5/tests$ cat /tmp/bar.js 
var hanidec_numbers = "〇一二三四五六七八九";
vlorentz@gommier:~/js/LambdaS5/tests$ ../bin/js --help
[…]
Version: JavaScript-C 1.8.5+ 2011-04-16
[…]
vlorentz@gommier:~/js/LambdaS5/tests$ ../bin/js -e "print(JSON.stringify(Reflect.parse(read('/tmp/bar.js'))))"
{"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":35},"source":null},"type":"Program","body":[{"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":34},"source":null},"type":"VariableDeclaration","kind":"var","declarations":[{"loc":{"start":{"line":1,"column":4},"end":{"line":1,"column":34},"source":null},"type":"VariableDeclarator","id":{"loc":{"start":{"line":1,"column":4},"end":{"line":1,"column":34},"source":null},"type":"Identifier","name":"hanidec_numbers"},"init":{"loc":{"start":{"line":1,"column":22},"end":{"line":1,"column":34},"source":null},"type":"Literal","value":"

This bug has been fixed in the current version of SpiderMonkey. I also had to update a part of of js/spiderMonkey.ml as SpiderMonkey now supports only one handler in try…catch blocks.

I also updated the symlink bin/js to the newest x86_64 version (the i686 version no longer works on x86_64 architecture because of .so handling)

(PS: For some reason, GitHub wants to merge commits Fix test case tests/unit-tests/regexp-exec.js and Move forgotten file., while you already merged them)

progval added 3 commits June 17, 2014 15:48
Execution of this test case:
* First call:
  |foo bar baz
  foo| bar baz
  foo bar |baz
  -> "baz" is pushed to the end of the list, l is ["baz"]
* Second call:
  foo bar baz|
  |foo bar baz
  foo |bar baz
  -> "bar" is pushed to the end of the list, l is ["baz", "bar"]
etc.
@progval progval changed the title Update spidermonkey Update spideronkey Jun 17, 2014
@progval progval changed the title Update spideronkey Update SpiderMonkey binaries Jun 17, 2014
…e has been removed is recent versions of SpiderMonkey.
@progval
Copy link
Contributor Author

progval commented Jun 19, 2014

Oh, and this patch also fixes #25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant