Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .rec extensions to whitelist #158

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Added .rec extensions to whitelist #158

merged 4 commits into from
Jan 17, 2024

Conversation

rdrighetto
Copy link
Contributor

Fixes #156

@brisvag
Copy link
Owner

brisvag commented Jan 17, 2024

Thanks! It can also be added below on the dispatch to the image writer below (I can't suggest through github cause it's too far from the current change). I wouldn't add to labels cause those are either masks or segmentations, and I doubt they should use the .rec extension.

I also added the same to cryohub, cause it needs to dispatch to the correct read function. So we should update the dependency here in pyproject.toml to the next version (I'll release soon, it will be 0.6.3).

Copy link
Owner

@brisvag brisvag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brisvag
Copy link
Owner

brisvag commented Jan 17, 2024

I pushed the dependency change as well to your branch, then we should be good to go!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31333c7) 42.94% compared to head (0b05218) 42.94%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   42.94%   42.94%           
=======================================
  Files          10       10           
  Lines         489      489           
=======================================
  Hits          210      210           
  Misses        279      279           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brisvag brisvag merged commit afd2168 into brisvag:main Jan 17, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor issue: expected MRC file extension
3 participants