-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-163590 - Update bundler and add package.json dependencies back in #124234
Conversation
Closing pull request because all |
ci:reopen |
Merged. Thank you. |
Thx @bryceosterhaus @natocesarrego fyi! @ling-alan-huang we can probably remove JSONPackageJSONRedundantDependenciesCheck if the code here works and the paradigm has changed. |
Thanks for lettting me know, @brianchandotcom! 🙂 The build times shared by @bryceosterhaus were extracted on my machine by the script created by you, the Thanks everybody! |
I additionally created this issue to investigate some other build time impacts from our frontend toolset, liferay/liferay-frontend-projects#1026 |
Manual Forward from: liferay-frontend#2753
@brianchandotcom, follow the PR conversation to see discussion on build time performance from this PR.
tldr;
Build times slightly increase, although these times may have been impacted by network speeds and thus making the time difference negligible.
I believe there are additional FE improvements we can make to
increasedecrease the build times as well.Additionally, by adding these dependencies back in, our typescript generation should become more accurate.
Let me know if you have any questions/concerns
https://issues.liferay.com/browse/LPS-163590